Re: [PATCH] cifs: use discard iterator to discard unneeded network data more efficiently

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Aurélien Aptel <aaptel@xxxxxxxx> wrote:

> > +{
> > +	struct msghdr smb_msg;
> > +
> > +	iov_iter_discard(&smb_msg.msg_iter, READ, to_read);
> > +
> > +	return cifs_readv_from_socket(server, &smb_msg);
> > +}
> > +
> 
> Shouldn't smb_msg be initialized to zeroes? Looking around this needs to
> be done for cifs_read_from_socket() and cifs_read_page_from_socket() too.

Yeah - I think you're right.  I didn't manage to finish making the changes,
so what I gave to Steve wasn't tested.

David





[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux