Re: [PATCH 1/4] cifs: New optype for session operations.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 9, 2021 at 1:58 PM Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote:
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 50fcb65920e8..1a1f9f4ae80a 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1704,7 +1704,8 @@ static inline bool is_retryable_error(int error)
>  #define   CIFS_ECHO_OP      0x080    /* echo request */
>  #define   CIFS_OBREAK_OP   0x0100    /* oplock break request */
>  #define   CIFS_NEG_OP      0x0200    /* negotiate request */
> -#define   CIFS_OP_MASK     0x0380    /* mask request type */
> +#define   CIFS_SESS_OP     0x2000    /* session setup request */
> +#define   CIFS_OP_MASK     0x2380    /* mask request type */
>
> Why skipping 0x400, 0x800 and 0x1000 flags?

They were already reserved.  See cifsglob.h

#define   CIFS_HAS_CREDITS 0x0400    /* already has credits */
#define   CIFS_TRANSFORM_REQ 0x0800    /* transform request before sending */
#define   CIFS_NO_SRV_RSP    0x1000    /* there is no server response */



-- 
Thanks,

Steve



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux