I had missed one check where CIFS_SESS_OP also had to be checked. Not
doing so would disable echoes and oplocks.
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index f19274857292..43331555fcc5 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -84,7 +84,7 @@ smb2_add_credits(struct TCP_Server_Info *server,
pr_warn_once("server overflowed SMB3 credits\n");
}
server->in_flight--;
- if (server->in_flight == 0 && (optype & CIFS_OP_MASK) != CIFS_NEG_OP)
+ if (server->in_flight == 0 && (optype & CIFS_OP_MASK) !=
CIFS_NEG_OP && (optype & CIFS_OP_MASK) != CIFS_SESS_OP)
rc = change_conf(server);
/*
* Sometimes server returns 0 credits on oplock break ack - we need to
Attaching a revised patch (one line correction in the old one).
Regards,
Shyam
On Thu, Feb 4, 2021 at 2:04 AM Aurélien Aptel <aaptel@xxxxxxxx> wrote:
>
>
> LGTM
>
> Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx>
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
>
--
Regards,
Shyam
Attachment:
0001-cifs-New-optype-for-session-operations.patch
Description: Binary data
