On Sat, Jan 02, 2021 at 06:19:39PM -0600, Steve French wrote:
I agree with the idea of being safe (in the smbclient in this case), and not returning potentially dangerous file names (even if a very remote danger to the tool, smbclient in this case), but I am not convinced that the "user friendly" behavior is to reject the names with the rather confusing message - especially as it would mean that inserting a single file with an odd name into a server could make the whole share unusable for smbclient (e.g. in a backup scenario). I agree with rejecting (or perhaps better skipping) it, but ... not sure any user would understand what SMBecho has to do with a server file name.
Dropping the connection on receipt of an invalid name is the only safe response. We know the server is insane and dangerous at that point and sending invalid protocol responses. Safer not to continue.
"NT_STATUS_INVALID_NETWORK_RESPONSE listing \* smb: \> SMBecho failed (NT_STATUS_CONNECTION_DISCONNECTED). The connection is disconnected now"
The SMBecho is due to the keepalive failing once the connection was dropped.
