Hi Boris, Are you talking about this patch "[PATCH] Extend cifs acl utilities to handle SACLs"? Just for the future, I am trying to monitor the samba-dev mailing list but if you would like to get the fastest response to your patches then please include me directly or at least the linux-cifs mailing list. I stage pending patches in the "next" branch on my github tree, so, will include the one above. https://github.com/piastry/cifs-utils/commits/next -- Best regards, Pavel Shilovsky пн, 7 дек. 2020 г. в 07:28, Boris Protopopov <boris.v.protopopov@xxxxxxxxx>: > > Hello, Shyam, > > sorry for the delayed reply and thanks for looking at this patch. Yes, > the testing was done using the extended versions of > getcifsacl/setcifsacl (added setting owner and SACL support), the > patch for that posted recently via samba-technical (message ID > <20201120214918.12517-1-pboris@xxxxxxxxxx>). I have tested > setting/getting the owner, DACL, and SACL, for all the DACL/SACL flags > (-a, -D, -M, -S), SACL type SYSTEM_AUDIT. This testing was done > against 5.10.0-rc1 and 4.14.203 (the latter required porting the > user-space patch). I believe this testing has fully exercised the code > changes in question. > > I will look at contributing to the fsxtesting-cifs code, but I think > the setcifsacl/getcifsact patch that enables easy access to the > descriptor components is a pre-requisite for such contributions. > > Thanks! > > > On Wed, Dec 2, 2020 at 5:43 AM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > > > Hi Boris, > > > > At a high level, the changes look good to me. Will go through the > > changes in more detail tomorrow morning. > > > > On a related note, we may need more test coverage in this area. > > Can you please share your testing output against your changes? > > Or even better, if you can contribute some xfstests for this use case: > > https://wiki.samba.org/index.php/Xfstesting-cifs > > > > Regards, > > Shyam > > > > On Wed, Dec 2, 2020 at 12:24 AM Boris Protopopov > > <boris.v.protopopov@xxxxxxxxx> wrote: > > > > > > Hello, > > > I am checking in to see if anyone had a chance to take a look at this > > > patch. I would appreciate any feedback. > > > Thanks! > > > > > > On Tue, Oct 27, 2020 at 5:01 PM Boris Protopopov via samba-technical > > > <samba-technical@xxxxxxxxxxxxxxx> wrote: > > > > > > > > Add SYSTEM_SECURITY access flag and use with smb2 when opening > > > > files for getting/setting SACLs. Add "system.cifs_ntsd_full" > > > > extended attribute to allow user-space access to the functionality. > > > > Avoid multiple server calls when setting owner, DACL, and SACL. > > > > > > > > Signed-off-by: Boris Protopopov <pboris@xxxxxxxxxx> > > > > --- > > > ... > > > > > > > > -- > > -Shyam
