Looks good! On Fri, Dec 4, 2020 at 9:12 AM Steve French <smfrench@xxxxxxxxx> wrote: > > Updated with Ronnie's suggestion. > > > On Thu, Dec 3, 2020 at 4:08 PM ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote: > > > > LGTM. > > > > Maybe move acl.AclRevision down to where the other fields are assigned > > so they are all assigned in the same place? > > > > On Fri, Dec 4, 2020 at 2:46 AM Steve French <smfrench@xxxxxxxxx> wrote: > > > > > > updated the patch slightly by creating local variable for ace_count > > > and acl_size to avoid excessive endian conversions > > > > > > On Mon, Nov 30, 2020 at 10:19 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > > > > > Updated patch with fixes for various endian sparse warnings > > > > > > > > > > > > On Mon, Nov 30, 2020 at 12:02 AM Steve French <smfrench@xxxxxxxxx> wrote: > > > > > > > > > > When mounting with "idsfromsid" mount option, Azure > > > > > corrupted the owner SIDs due to excessive padding > > > > > caused by placing the owner fields at the end of the > > > > > security descriptor on create. Placing owners at the > > > > > front of the security descriptor (rather than the end) > > > > > is also safer, as the number of ACEs (that follow it) > > > > > are variable. > > > > > > > > > > -- > > > > > Thanks, > > > > > > > > > > Steve > > > > > > > > > > > > > > > > -- > > > > Thanks, > > > > > > > > Steve > > > > > > > > > > > > -- > > > Thanks, > > > > > > Steve > > > > -- > Thanks, > > Steve
