On Wed, Dec 2, 2020 at 7:52 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > On Friday, I made similar changes as a part of my changes for sending > default sec_desc, while testing against Azure. > The idea is similar to Ronnie's patch. Move the owner and group SIDs > up and push down the DACL. > In addition to the changes Ronnie made, it looks like the 8-byte > alignment is required for few of the other offset fields too. > Hopefully, I'll have it tested out by EOD, and send out another patch. Nice, but what types need 8 byte alignment did you find? MS-DTYP says that for self relative security descriptors that padding is not required. (section 2.4.6) If this is the case we might need to involve dochelp. > > Regards, > Shyam > > On Tue, Dec 1, 2020 at 9:54 AM Steve French <smfrench@xxxxxxxxx> wrote: > > > > Updated patch with fixes for various endian sparse warnings > > > > > > On Mon, Nov 30, 2020 at 12:02 AM Steve French <smfrench@xxxxxxxxx> wrote: > > > > > > When mounting with "idsfromsid" mount option, Azure > > > corrupted the owner SIDs due to excessive padding > > > caused by placing the owner fields at the end of the > > > security descriptor on create. Placing owners at the > > > front of the security descriptor (rather than the end) > > > is also safer, as the number of ACEs (that follow it) > > > are variable. > > > > > > -- > > > Thanks, > > > > > > Steve > > > > > > > > -- > > Thanks, > > > > Steve > > > > -- > -Shyam
