Re: [SMB3][PATCH] ifs: refactor create_sd_buf() and and avoid corrupting the buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, I made similar changes as a part of my changes for sending
default sec_desc, while testing against Azure.
The idea is similar to Ronnie's patch. Move the owner and group SIDs
up and push down the DACL.
In addition to the changes Ronnie made, it looks like the 8-byte
alignment is required for few of the other offset fields too.
Hopefully, I'll have it tested out by EOD, and send out another patch.

Regards,
Shyam

On Tue, Dec 1, 2020 at 9:54 AM Steve French <smfrench@xxxxxxxxx> wrote:
>
> Updated patch with fixes for various endian sparse warnings
>
>
> On Mon, Nov 30, 2020 at 12:02 AM Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > When mounting with "idsfromsid" mount option, Azure
> > corrupted the owner SIDs due to excessive padding
> > caused by placing the owner fields at the end of the
> > security descriptor on create.  Placing owners at the
> > front of the security descriptor (rather than the end)
> > is also safer, as the number of ACEs (that follow it)
> > are variable.
> >
> > --
> > Thanks,
> >
> > Steve
>
>
>
> --
> Thanks,
>
> Steve



-- 
-Shyam



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux