Re: [PATCH] Convert trailing spaces and periods in path components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I agree with testing, but also, looking at the comments:

/*
 * Convert 16 bit Unicode pathname to wire format from string in
current code
 * page. Conversion may involve remapping up the six characters that
are
 * only legal in POSIX-like OS (if they are present in the string).
Path
 * names are little endian 16 bit Unicode on the wire
 */
int
cifsConvertToUTF16(__le16 *target, const char *source, int srclen,
                 const struct nls_table *cp, int map_chars)
{
        int i, charlen;
        int j = 0;
        char src_char;
        __le16 dst_char;
        wchar_t tmp;
        wchar_t *wchar_to;      /* UTF-16 */
        int ret;
        unicode_t u;

        if (map_chars == NO_MAP_UNI_RSVD)
                return cifs_strtoUTF16(target, source, PATH_MAX, cp);

...

it would seem that as long as the correct map_chars is picked, it
should work correctly? The latter, if not automatically determined,
can be controlled with mount options, I believe.

Boris.

On Wed, Sep 30, 2020 at 5:25 AM Aurélien Aptel <aaptel@xxxxxxxx> wrote:
>
> Steve French <smfrench@xxxxxxxxx> writes:
> > tentatively merged ... running the usual functional tests
> > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/399
>
> We need to make sure it works with samba smb1&smb2 posix extensions.
> In smb1 posix extensions the paths are sent with / and \ is a valid
> component (and no restrictions on file name endings).
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux