Ok. Checked the test. It does a multiuser mount of a file share. (I'm assuming this is using sec=ntlmssp) Then does an "ls" on the mount point as another user. Expects EACCES as the output. With this change, the command returns an ENOKEY. With the credentials added to keyring using cifscreds, the ls command works. Now the question is: Is the right error to return here EACCES or ENOKEY? Even if the expected error here should be EACCES, I'd say that the error returned by cifs_set_cifscreds should return that error. Regards, Shyam On Wed, Sep 30, 2020 at 8:48 PM Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote: > > It looks like xfstests smb3 multiuser cifsutils-101 and cifs-101 are failing. > Maybe they were written keeping in mind the current error code > returned by cifs.ko in this situation? Let me take a look. > I guess @ronnie sahlberg will be able to debug the failing tests > faster. The failing test has his name in the code. :) > > On Tue, Sep 29, 2020 at 11:16 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > tentatively merged ... running the usual functional tests > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/399 > > > > On Tue, Sep 29, 2020 at 8:16 AM Aurélien Aptel <aaptel@xxxxxxxx> wrote: > > > > > > Shyam Prasad N <nspmangalore@xxxxxxxxx> writes: > > > > One of the cases where this behaviour is confusing is where a > > > > new tcon needs to be constructed, but it fails due to > > > > expired keys. cifs_construct_tcon then returns ENOKEY, > > > > but we end up returning a EACCES to the user. > > > > > > > > Signed-off-by: Shyam Prasad N <sprasad@xxxxxxxxxxxxx> > > > > > > LGTM > > > > > > Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx> > > > > > > Cheers, > > > -- > > > Aurélien Aptel / SUSE Labs Samba Team > > > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > > > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > > > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München) > > > > > > > > -- > > Thanks, > > > > Steve > > > > -- > -Shyam -- -Shyam
