Re: lock checking issues (was: Re: [PATCH v3] cifs: Fix leak when handling lease break for cached root fid)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-07-07 15:05:09 +0200, Luc Van Oostenryck wrote:
To be honnest I'm not sure, these seem counterproductive. If you are
indicating you are acquiring X but lock Y the next line it feels like we
are fighting the tool instead of letting it help us.

__acquire() & __release() should only be used by locking primitives.

Alright, thanks! (I did see several other locations in the kernel that seemed to be doing this, though I agree with Aurélien that it didn't feel right to be fighting sparse, and it's possible my attempt was more egregious.)

I will try to find a better way to organize the functionality that satisfies both the functionality and sparse.

Thanks,
~Paul




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux