Paul Aurich <paul@xxxxxxxxxxxxxx> writes: > Changes since v2: > - address sparse lock warnings by inlining smb2_tcon_has_lease and > hardcoding some return values (seems to help sparse's analysis) Ah, I think the issue is not the inlining but rather you need to instruct sparse that smb2_tcon_hash_lease is expected to release the lock. https://www.kernel.org/doc/html/v4.12/dev-tools/sparse.html#using-sparse-for-lock-checking Probably with __releases somewhere in the func prototype. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)