Agree. Both SMB2_open_init and SMB2_query_info_init should exit through oshr_free to avoid double unlock. -- Best regards, Pavel Shilovsky пт, 13 сент. 2019 г. в 07:36, Aurélien Aptel <aaptel@xxxxxxxx>: > > Aurélien Aptel <aaptel@xxxxxxxx> writes: > > Good catch. Since the compounding changes it is SMB2_open_init() that is > > triggering the reconnect -> mark_open_files_invalid() code path so it > > looks good to me. Might be worth updating the comment to > > s/SMB2_open/SMB2_open_init/ before you commit. > > Ah it seems you also need to make SMB2_open_init exit via the oshr_free > label otherwise you the mutex gets unlocked twice (see Dan Carpenter > automatic test email). This smatch tool is pretty nice... > > Cheers > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE > GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
