"Steve French" <smfrench@xxxxxxxxx> writes: > + /* > + * We do not hold the lock for the open because in case > + * SMB2_open needs to reconnect, it will end up calling > + * cifs_mark_open_files_invalid() which takes the lock again > + * thus causing a deadlock > + */ > + > + mutex_unlock(&tcon->crfid.fid_mutex); > + Good catch. Since the compounding changes it is SMB2_open_init() that is triggering the reconnect -> mark_open_files_invalid() code path so it looks good to me. Might be worth updating the comment to s/SMB2_open/SMB2_open_init/ before you commit. Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx> Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
