Fixed with a different patch following Pavel's suggestion - (a followon to Aurelien's open_shroot hang patch) On Thu, Sep 12, 2019 at 12:01 PM Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > > We need to skip TreeDisconnect command if tcon->need_reconnect is > true. Steve, could you add this to the patch? > -- > Best regards, > Pavel Shilovsky > > ср, 11 сент. 2019 г. в 15:10, ronnie sahlberg <ronniesahlberg@xxxxxxxxx>: > > > > On Thu, Sep 12, 2019 at 3:08 AM Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > > > > > > can this error code be returned on any operation? > > > > Not sure. > > I think it is only returned by TreeConnect and possibly also > > SessionSetup, but not sure. > > > > > > > -- > > > Best regards, > > > Pavel Shilovsky > > > > > > вт, 10 сент. 2019 г. в 22:26, ronnie sahlberg <ronniesahlberg@xxxxxxxxx>: > > > > > > > > Looks good. > > > > > > > > > > > > We also need to handle the case where the share is deleted but is > > > > never added back. > > > > > > > > On Wed, Sep 11, 2019 at 3:15 PM Steve French <smfrench@xxxxxxxxx> wrote: > > > > > > > > > > When a share is deleted, returning EIO is confusing and no useful > > > > > information is logged. Improve the handling of this case by > > > > > at least logging a better error for this (and also mapping the error > > > > > differently to EREMCHG). See e.g. the new messages that would be logged: > > > > > > > > > > [55243.639530] server share \\192.168.1.219\scratch deleted > > > > > [55243.642568] CIFS VFS: \\192.168.1.219\scratch BAD_NETWORK_NAME: > > > > > \\192.168.1.219\scratch > > > > > > > > > > In addition for the case where a share is deleted and then recreated > > > > > with the same name, have now fixed that so it works. This is sometimes > > > > > done for example, because the admin had to move a share to a different, > > > > > bigger local drive when a share is running low on space. > > > > > > > > > > -- > > > > > Thanks, > > > > > > > > > > Steve -- Thanks, Steve
