merged into cifs-2.6.git for-next On Wed, Jul 31, 2019 at 10:54 AM Colin Ian King <colin.king@xxxxxxxxxxxxx> wrote: > > On 31/07/2019 16:34, Aurélien Aptel wrote: > > "Dan Carpenter" <dan.carpenter@xxxxxxxxxx> writes: > >> You're just turning off GCC's static analysis (and introducing false > >> positives) when you do that. We have seen bugs caused by this and never > >> seen any bugs prevented by this style. > > > > You've never seen bugs prevented by initializing uninitialized > > variables? Code can change overtime and I don't think coverity is > > checked as often as it could be, meaning the var could end up being used > > while uninitialized in the future. > > gcc/clang should pick up uninitialized vars at compile time. also I run > coverity daily on linux-next. > > Colin > > > > > Anyway I won't die on this hill, merge this if you prefer. > > > > Cheers, > > > -- Thanks, Steve
