Colin King <colin.king@xxxxxxxxxxxxx> writes: > Variable rc is being initialized with a value that is never read > and rc is being re-assigned a little later on. The assignment is > redundant and hence can be removed. I think I would actually rather have rc set to an error by default than uninitialized. Just my personal opinion. Cheers, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
