On Mon, Jun 24, 2019 at 4:41 PM ronnie sahlberg
<ronniesahlberg@xxxxxxxxx> wrote:
>
> On Tue, Jun 25, 2019 at 7:24 AM Steve French <smfrench@xxxxxxxxx> wrote:
> >
> > In Aurelien's earlier patch series I noticed a cleanup (converting
> > ses->server to a local variable server=ses->server) which made code
> > easier to read in this function. This doesn't require compounding but
> > probably helps his
> >
>
> LGTM.
>
> Possibly initialize server where you declare it as we do that for
> *server almost everywhere else :
>
> + struct TCP_Server_Info *server = ses->server;
I didn't set it there because later in the function we check:
if ((ses == NULL) || (ses->server == NULL))
so I need to make sure the assignment is after the null check
(even if the null check is superfluous it would trigger a static check
warning to initialize server before the null check)
--
Thanks,
Steve
