Re: Minor cleanup of compound_send_recv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 25, 2019 at 7:24 AM Steve French <smfrench@xxxxxxxxx> wrote:
>
> In Aurelien's earlier patch series I noticed a cleanup (converting
> ses->server to a local variable server=ses->server) which made code
> easier to read in this function.  This doesn't require compounding but
> probably helps his
>

LGTM.

Possibly initialize server where you declare it as we do that for
*server almost everywhere else :

+ struct TCP_Server_Info *server = ses->server;

Reviewed-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>

>
>
> --
> Thanks,
>
> Steve



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux