Maybe we should change the option "acl|noacl" to "posixacl|noposixacl". ----- Original Message ----- > From: "Xiaoli Feng" <xifeng@xxxxxxxxxx> > To: "Steve French" <smfrench@xxxxxxxxx> > Cc: "CIFS" <linux-cifs@xxxxxxxxxxxxxxx>, "fengxiaoli0714@xxxxxxxx" <fengxiaoli0714@xxxxxxxxx> > Sent: Wednesday, April 10, 2019 11:40:16 AM > Subject: Re: [PATCH v2] CIFS: display noacl in the mount options > > Yes, could get users confused. But from the Man page: > > noacl Do not allow POSIX ACL operations even if server would support > them. > The CIFS client can get and set POSIX ACLs (getfacl, > setfacl) to Samba servers version 3.0.10 and later. Setting > POSIX ACLs requires enabling both CIFS_XATTR and then > CIFS_POSIX support in the CIFS configuration options when > building the cifs module. POSIX ACL support can be disabled on > a per mount basis by specifying noacl on mount. > > cifsacl > This option is used to map CIFS/NTFS ACLs to/from Linux > permission bits, map SIDs to/from UIDs and GIDs, and get and > set Security Descriptors. > See section on CIFS/NTFS ACL, SID/UID/GID MAPPING, SECURITY > DESCRIPTORS for more information. > > These two options are for different ACL. There is still a option "acl". It > also can be mounted with cifsacl together for SMB1.0. > There are some errors in my commit log. Should say "smb2.0+ don't support > POSIX ACL". What do you think about this patch? It also > makes sense if doesn't display "noacl". > > ----- Original Message ----- > > From: "Steve French" <smfrench@xxxxxxxxx> > > To: "XiaoLi Feng" <xifeng@xxxxxxxxxx> > > Cc: "CIFS" <linux-cifs@xxxxxxxxxxxxxxx>, "fengxiaoli0714@xxxxxxxx" > > <fengxiaoli0714@xxxxxxxxx> > > Sent: Wednesday, April 10, 2019 10:56:19 AM > > Subject: Re: [PATCH v2] CIFS: display noacl in the mount options > > > > Could this get users confused who mount with "cifsacl" and see "noacl" as > > well? > > > > Also this is really saying no support for "POSIX (draft standard) ACL > > support" not no support for SMB3 ACL (or similarly "RichACL" or NFS > > ACL or ... NTFS ACL or ... which are somewhat similar and common). > > > > Could get confusing > > > > On Tue, Apr 9, 2019 at 8:43 PM XiaoLi Feng <xifeng@xxxxxxxxxx> wrote: > > > > > > From: "fengxiaoli0714@xxxxxxxx" <fengxiaoli0714@xxxxxxxxx> > > > > > > The mount option noacl aren't shown in /proc/mounts > > > even if they are mounted successfully. And smb2.0+ > > > don't support ACL. Display noacl acquiescently if ACL > > > is unsupported. > > > > > > Signed-off-by: fengxiaoli0714@xxxxxxxx <fengxiaoli0714@xxxxxxxxx> > > > --- > > > fs/cifs/cifsfs.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c > > > index f9b71c12cc9f..80ee4fbcd25b 100644 > > > --- a/fs/cifs/cifsfs.c > > > +++ b/fs/cifs/cifsfs.c > > > @@ -535,6 +535,8 @@ cifs_show_options(struct seq_file *s, struct dentry > > > *root) > > > seq_puts(s, ",dynperm"); > > > if (root->d_sb->s_flags & SB_POSIXACL) > > > seq_puts(s, ",acl"); > > > + else > > > + seq_puts(s, ",noacl"); > > > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS) > > > seq_puts(s, ",mfsymlinks"); > > > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE) > > > -- > > > 2.18.1 > > > > > > > > > -- > > Thanks, > > > > Steve > > >
