Could this get users confused who mount with "cifsacl" and see "noacl" as well? Also this is really saying no support for "POSIX (draft standard) ACL support" not no support for SMB3 ACL (or similarly "RichACL" or NFS ACL or ... NTFS ACL or ... which are somewhat similar and common). Could get confusing On Tue, Apr 9, 2019 at 8:43 PM XiaoLi Feng <xifeng@xxxxxxxxxx> wrote: > > From: "fengxiaoli0714@xxxxxxxx" <fengxiaoli0714@xxxxxxxxx> > > The mount option noacl aren't shown in /proc/mounts > even if they are mounted successfully. And smb2.0+ > don't support ACL. Display noacl acquiescently if ACL > is unsupported. > > Signed-off-by: fengxiaoli0714@xxxxxxxx <fengxiaoli0714@xxxxxxxxx> > --- > fs/cifs/cifsfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c > index f9b71c12cc9f..80ee4fbcd25b 100644 > --- a/fs/cifs/cifsfs.c > +++ b/fs/cifs/cifsfs.c > @@ -535,6 +535,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root) > seq_puts(s, ",dynperm"); > if (root->d_sb->s_flags & SB_POSIXACL) > seq_puts(s, ",acl"); > + else > + seq_puts(s, ",noacl"); > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS) > seq_puts(s, ",mfsymlinks"); > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE) > -- > 2.18.1 > -- Thanks, Steve
