Re: [PATCH] cifs: add IOCTL for QUERY_INFO passthrough to userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



For this there will be a whole bunch of defines and some structure
definitions that cifs-utils could share with the kernel.
Maybe we can split some of those, just structs and #defines for flags
and such into separate header files in cifs.ko that we
can share with userspace?

I might want to share those files and use them in libsmb2 too since we
are getting too many re-implementations of the same
 structures and fields already :-)


ronnie

On Mon, Sep 17, 2018 at 4:52 PM, Steve French <smfrench@xxxxxxxxx> wrote:
> Quotas, SACLs, Claims based ACLs, and even auditing info (and streams
> info) - all useful potentially for backup, debugging, misc. tools
> On Mon, Sep 17, 2018 at 1:51 AM ronnie sahlberg
> <ronniesahlberg@xxxxxxxxx> wrote:
>>
>> Would be really nice to do the plumbing to get SMB2_QUERY_QUOTA_INFO
>> working too so that we can surface the quota info to userspace.
>> Displaying true quota to userspace I think is still one of the larger
>> gaps we have.
>>
>> On Mon, Sep 17, 2018 at 1:48 PM, ronnie sahlberg
>> <ronniesahlberg@xxxxxxxxx> wrote:
>> > On Mon, Sep 17, 2018 at 4:42 AM, Aurélien Aptel <aaptel@xxxxxxxx> wrote:
>> >> Tom Talpey <ttalpey@xxxxxxxxxxxxx> writes:
>> >>> I think it's a mistake to name anything beginning with "cifs" in
>> >>> today's world. I suggest "smbfileinfo". But isn't this really just
>> >>> an extended version of stat(1)? Would a name in line with that
>> >>> usage be more appropriate?
>> >>
>> >> Yes cifsstat or smbstat sounds a lot better indeed.
>> >>
>> >> As for cifs vs smb, unfortunately "cifs" is used *everywhere* in the
>> >> cifs-utils package. The name, the utilities name, the man pages,
>> >> configure options, etc. I've tried to use SMB in the man page but it
>> >> makes the package a bit inconsistent. Ideally we should rename
>> >> everything but that's going to break a lot of stuff downstream.
>> >
>> > smbstat would be really nice.  And have it implement all the info levels that
>> > QUERY_INFO supports.
>> >
>> >
>> >>
>> >> Cheers,
>> >> --
>> >> Aurélien Aptel / SUSE Labs Samba Team
>> >> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
>> >> SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
>> >> GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
>
>
>
> --
> Thanks,
>
> Steve




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux