Got a build break with it commit 6c680d47cf25aecdb31b608b4d4191b086b71ccf Author: Paulo Alcantara <paulo@xxxxxxxx> Date: Fri Jun 15 12:41:28 2018 -0300 cifs: Use correct packet length in SMB2_TRANSFORM header CC [M] fs/cifs/smbdirect.o fs/cifs/smbdirect.c: In function ‘smbd_send’: fs/cifs/smbdirect.c:2120:11: error: implicit declaration of function ‘smb2_rqst_len’; did you mean ‘smbd_post_send’? [-Werror=implicit-function-declaration] buflen = smb2_rqst_len(rqst, true); ^~~~~~~~~~~~~ smbd_post_send On Fri, Jun 15, 2018 at 10:55 AM, Aurélien Aptel <aaptel@xxxxxxxx> wrote: > > Good catch! Refactoring looks good to me. > > Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx> > > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html