I agree that something like this would be cleaner - needs more testing too ... am backing this fix out for time being. On Thu, Apr 12, 2018 at 4:59 PM, Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > 2018-04-11 23:05 GMT-07:00 Steve French <smfrench@xxxxxxxxx>: >> Windows doesn't always return . and .. (e.g.) for when you mount to >> equivalent of C$ >> this causes first two directory entries to be skipped. Patch attached >> which seems to fix it (more testing would be appreciated) >> >> I suspect that there is a better way to fix this - anyone see a better >> way. Problem is that if we rely on ctx->pos to determine where we are >> in the buffer we end up starting on entry 3 in the serach results ... >> but entry 1 and 2 are not always . and .. (as we see in shares in >> windows to the root of a drive). >> >> Any better ideas? >> >> >> >> -- >> Thanks, >> >> Steve > > > > Can we make SM2_query_directory() and FindFirst() return a predictable > format of output by removing . and .. for the response buffer (if they > exist)? This will allow us to make cifs_readdir() cleaner. > > -- > Best regards, > Pavel Shilovsky -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
