Re: [PATCH] CIFS: do not send invalid input buffer on QUERY_INFO requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 18/10/2017 à 16:50, Aurélien Aptel a écrit :
Hadrien Grasland <grasland@xxxxxxxxxxxx> writes:
Just tried out this patch, and the CIFS module does indeed produce
well-formed GetInfo requests now (according to Wireshark's definition at
least, didn't check myself).

However, the server will still reject the request with a
STATUS_NOT_SUPPORTED error, suggesting that Steve's interpretation was
the right one: this is likely a server-side bug.
Yes. As Steve suggested as a workaround, we could try to use a less
detailed information level if FullInfo fails. Is it worth doing for a
single old NetApp server?

If it's only me that's having the issue, I would say don't bother. The same system issue that prevents my sysadmin colleagues from updating to a NetApp software version where the bug is fixed also prevents them from disabling SMBv1 support, and sticking with SMBv1 for now is fine by me.


As for the offset and extra byte in QUERY_INFO I guess having the length
set to 0 makes it ok... I've sent a couple of patches to Wireshark to
fix the packet parsing. It now accepts the empty filename in CREATE (no
more "[unknown]"), which enables the proper parsing of the unknown
field.
Thanks for looking into this!
Hadrien
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux