On Sun, 2014-08-03 at 01:13 +0200, Rickard Strandqvist wrote: > 2014-08-02 19:33 GMT+02:00 Joe Perches <joe@xxxxxxxxxxx>: > > On Sat, 2014-08-02 at 11:55 -0500, Shirish Pargaonkar wrote: > >> Acked-by: Shirish Pargaonkar <spargaonkar@xxxxxxxx> > > [] > >> > diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c > > [] > >> > @@ -307,7 +307,7 @@ int calc_lanman_hash(const char *password, const char *cryptkey, bool encrypt, > >> > > >> > memset(password_with_pad, 0, CIFS_ENCPWD_SIZE); > >> > if (password) > >> > - strncpy(password_with_pad, password, CIFS_ENCPWD_SIZE); > >> > + strncpy(password_with_pad, password, CIFS_ENCPWD_SIZE - 1); > > > > > > Is this always correct? [] > Because password_with_pad gets set to all zeros above, the character, > I do not guarantee a copy terminating null. > Unless it is so that you do not want any terminating null. That's the question for Steve and cifs people. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
