On Sat, 2014-08-02 at 11:55 -0500, Shirish Pargaonkar wrote: > Acked-by: Shirish Pargaonkar <spargaonkar@xxxxxxxx> [] > > diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c [] > > @@ -307,7 +307,7 @@ int calc_lanman_hash(const char *password, const char *cryptkey, bool encrypt, > > > > memset(password_with_pad, 0, CIFS_ENCPWD_SIZE); > > if (password) > > - strncpy(password_with_pad, password, CIFS_ENCPWD_SIZE); > > + strncpy(password_with_pad, password, CIFS_ENCPWD_SIZE - 1); Is this always correct? -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html