On Wed, May 15, 2013 at 02:54:29PM -0400, J. Bruce Fields wrote: > On Wed, May 15, 2013 at 12:50:13PM -0500, Steve French wrote: > > Does nfs client ever have the case where two different superblocks map > > to the same nfs export (and thus the check below is restricting the > > ability to do server side copy)? > > > > + if (inode_in->i_sb != inode_out->i_sb || > > + file_in->f_path.mnt != file_out->f_path.mnt) > > + return -EXDEV; > > The client attempts to use the same superblock whenever it can. > > I suppose you're also losing the opportunity to copy between two > different filesystems on the same server, which should be faster than > requiring the client to do the copy. Ah, yeah, that'd probably be the simplest motivation to move this down into the ->copy_range methods. It should be trivial to test once the nfs bits are going and we have the page cache fallback. - z -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
