Re: [PATCH] cifs: ensure that cifs_readpages calls cifsFileInfo_get under the cifs_file_list_lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 20 Jul 2012 11:48:50 -0400
Jeff Layton <jlayton@xxxxxxxxxx> wrote:

> ...regression introduced in 6993f74a5.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
>  fs/cifs/file.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 513adbc..45508cf 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -3083,8 +3083,8 @@ static int cifs_readpages(struct file *file, struct address_space *mapping,
>  		}
>  
>  		spin_lock(&cifs_file_list_lock);
> -		spin_unlock(&cifs_file_list_lock);
>  		rdata->cfile = cifsFileInfo_get(open_file);
> +		spin_unlock(&cifs_file_list_lock);
>  		rdata->mapping = mapping;
>  		rdata->offset = offset;
>  		rdata->bytes = bytes;

Now that 3.5 has shipped, this patch needs to Cc: stable when it's included.

Cheers,
-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux