Re: [PATCH] mount.cifs: Use systemd's mechanism for getting password, if present

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 17 Jul 2012 19:28:09 +0530
Ankit Jain <jankit@xxxxxxxx> wrote:

> Hi Jeff,
> 
> On 06/26/2012 04:58 PM, Jeff Layton wrote:
> [snip]
> > It does, but we do have to concern ourselves with older versions of
> > systemd that might not, and with distros that might use systemd but not
> > add the tool (consider embedded distros). I think we'll need a
> > mechanism to fall back to the legacy password mechanism.
> 
> I'm guessing that by "legacy" you mean get_pass(..)? But on a regular
> systemd install, it takes over stdin/stdout, and the prompt won't come
> up on a terminal. But I don't know how it is set up on the other
> scenarios you mentioned. So, I'll do that but you will have to test it
> ;) I tried using /dev/tty, but in/out are redirected AFAIU, so, this
> didn't help.
> 
> > Also, a way to disable this at compile-time would nice. Maybe a
> > --enable-systemd autoconf option would be good that defaults to "on"
> > with a simple test to see if the build machine is running systemd?
> 
> Sure, autoconf option sounds good. But do we want to check for systemd
> running on the *build* machine (and choose default value for
> --enable-systemd accordingly)? Systemd running or not sounds like a
> runtime behavior, and we fall back to getpass anyway. I haven't added
> this in the attached patch, but if you feel that this makes sense, then
> I can add it.
> 
> Regards,

Merged...

-- 
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux