On Mon, Jan 16, 2012 at 6:57 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> On Mon, 16 Jan 2012 16:35:27 +0400
> Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote:
>
>> I noticed that when I run checkpatch.pl over my smb2 patches it fails on
>>
>> struct example {
>> ...
>> } __attribute__((packed));
>>
>> and suggests to use
>>
>> struct example {
>> ...
>> } __packed;
>>
>> Also we already have many such "style broken" structures in cifsdpu.h.
>>
>> What do you think about it? Should we fix them all?
>>
>
> Hmm interesting...there's some discussion of this a few months ago here:
>
> https://lkml.org/lkml/2011/6/22/25
>
> ...looks like __packed is a shortcut in the kernel's compiler-gcc.h
> header. Looks like using __packed is fine in new code as long as the
> header will never be used by userspace (which may not have that
> shortcut defined).
>
For new code it is good to make sure it is checkpatch clean
or reasonably close. I doubt it is worth the trouble to
go through cifspdu.h and change existing defines for something
like ihis, but for smb2pdu.h might as well make it clean.
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
