I noticed that when I run checkpatch.pl over my smb2 patches it fails on struct example { ... } __attribute__((packed)); and suggests to use struct example { ... } __packed; Also we already have many such "style broken" structures in cifsdpu.h. What do you think about it? Should we fix them all? -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html