On Mon, Oct 17, 2011 at 9:29 AM, Sachin Prabhu <sprabhu@xxxxxxxxxx> wrote: > On Tue, 2011-10-11 at 12:40 -0500, Steve French wrote: >> Looks reasonable - are we missing any more from the list of mount >> options that might matter to display? >> > When comparing the options parsed in cifs_parse_mount_options() and ones > shown in cifs_show_options(), there seems to be a few which are > missing. > > A quick list made by comparing the options parsed and displayed.. > sign > nostrictsync/strictsync > noperm/perm > iocharset > locallease > netbiosname > noautotune > noblocksnd > nodfs > port > prefixpath > sec > servern > sockopt > > Below is a simple patch which also includes the nostrictsync and noperm > mount options. > > Sachin Prabhu > -- > > Show nostrictsync and noperm mount options in /proc/mounts > > Add support to print nostrictsync and noperm mount options in /proc/mounts for shares mounted with these options. > > Signed-off-by: Sachin Prabhu <sprabhu@xxxxxxxxxx> > --- > fs/cifs/cifsfs.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c > index 54b8f1e..eb6e8bf 100644 > --- a/fs/cifs/cifsfs.c > +++ b/fs/cifs/cifsfs.c > @@ -432,6 +432,10 @@ cifs_show_options(struct seq_file *s, struct vfsmount *m) > seq_printf(s, ",mfsymlinks"); > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE) > seq_printf(s, ",fsc"); > + if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NOSSYNC) > + seq_printf(s, ",nostrictsync"); > + if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_PERM) > + seq_printf(s, ",noperm"); > > seq_printf(s, ",rsize=%d", cifs_sb->rsize); > seq_printf(s, ",wsize=%d", cifs_sb->wsize); I had to redo to avoid the merge conflict (your patch was not built on the previous one so conflicted with it) - but now merged. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
