On Mon, Jun 20, 2011 at 12:58 AM, Suresh Jayaraman <sjayaraman@xxxxxxx> wrote: > On 06/15/2011 08:12 PM, Steve French wrote: >> >> The idea of the 1st parameter to cerror was to allow turning off log >> spam more easily if error turned out to be expected. Gave some >> flexibility debugging too. > > Ok, but still it doesn't allow us to turn off logs in the runtime (have > to be recompiled, right?). OTOH, wouldn't be easier to convert a cERROR > to cFYI in case if we found if the error is expected or use cifswarn() > instead? Presumably could be turned off in a debugger as well. Originally the idea was that there would be a way to turn off cERROR (as we do with cFYI) at runtime too - not something that we would need unless we found log spamming annoying for errors running cifs mount to a particular buggy server (e.g.) for which we had not created a workaround yet. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
