On 06/14/2011 09:30 PM, Jeff Layton wrote:
> On Tue, 14 Jun 2011 21:07:47 +0530
> Suresh Jayaraman <sjayaraman@xxxxxxx> wrote:
>
>> ... for uniformity and cleaner debug logs.
>>
>> Signed-off-by: Suresh Jayaraman <sjayaraman@xxxxxxx>
>> ---
>> fs/cifs/cache.c | 6 +++---
>> fs/cifs/fscache.c | 53 +++++++++++++++++++++++++----------------------------
>> 2 files changed, 28 insertions(+), 31 deletions(-)
>>
>> diff --git a/fs/cifs/cache.c b/fs/cifs/cache.c
>> index dd8584d..545509c 100644
>> --- a/fs/cifs/cache.c
>> +++ b/fs/cifs/cache.c
>> @@ -92,7 +92,7 @@ static uint16_t cifs_server_get_key(const void *cookie_netfs_data,
>> break;
>>
>> default:
>> - cERROR(1, "CIFS: Unknown network family '%d'", sa->sa_family);
>> + cERROR(1, "Unknown network family '%d'", sa->sa_family);
> ^^^^^^^^^
> Maybe this would be a good time to add in a new
> cFYI/cERROR "flag" for fscache and convert all of these
> to use it?
Sounds like a good idea to flag fsc debug messages separately but
flagging errors separately would be useful?
Also, I don't understand the idea behing the "set" currently.
we have
#define cFYI(set, fmt, arg...) \
do { \
if (set) \
cifsfyi(fmt, ##arg); \
} while (0)
and we call cFYI with always pass like this:
cFYI(1, "..");
--
Suresh Jayaraman
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
