Re: [PATCH] CIFS: Simplify invalidate part (try #5)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



merged

On Fri, May 20, 2011 at 6:30 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> On Fri, 20 May 2011 13:00:53 +0400
> Pavel Shilovsky <piastry@xxxxxxxxxxx> wrote:
>
>> 2011/5/19 Jeff Layton <jlayton@xxxxxxxxxx>:
>> > On Sat, 23 Apr 2011 17:30:17 +0400
>> > Pavel Shilovsky <piastry@xxxxxxxxxxx> wrote:
>> >
>> >> Simplify many places when we call cifs_revalidate/invalidate to make
>> >> it do what it exactly needs.
>> >>
>> >> Signed-off-by: Pavel Shilovsky <piastry@xxxxxxxxxxx>
>> >> ---
>> >>  fs/cifs/cifsfs.c |   33 +++++++++++-----
>> >>  fs/cifs/cifsfs.h |    4 +-
>> >>  fs/cifs/file.c   |   16 ++++++--
>> >>  fs/cifs/inode.c  |  117 ++++++++++++++++++++++++++++++++++-------------------
>> >>  4 files changed, 113 insertions(+), 57 deletions(-)
>> >>
>> >
>> > This patch is causing a regression in tests5:
>> >
>> > ./test5: read and write
>> >        ./test5: (/mnt/salusa/rawhide.test) 'bigfile' has size -2130066000, should be 1048576
>> > basic tests failed
>> >
>> > Pavel, can you track this down?
>> >
>> > Steve, in the meantime I suggest that this patch not be pushed when
>> > the merge window opens.
>> >
>>
>> I figured it out.
>>
>> Steve, I attach two diffs: 1) diff for this version of the patch and
>> 2) new fixed version of the whole patch - you can use either one that
>> is more comfortable to you.
>>
>
> Confirmed -- the patch seems to fix the issue. With that, all the
> connectathon tests seem to now pass.
>
> --
> Jeff Layton <jlayton@xxxxxxxxxx>
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux