Re: [PATCH] cifs: Don't offer NFS export in Kconfig if nfsd is not enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Apr 2011 15:22:27 +0100
Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> There's no point in supporting NFS export of filesystems if we don't have
> nfsd in the first place.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  fs/cifs/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
> index 75c47cd..61e5f95 100644
> --- a/fs/cifs/Kconfig
> +++ b/fs/cifs/Kconfig
> @@ -175,6 +175,6 @@ config CIFS_SMB2
>  
>  config CIFS_NFSD_EXPORT
>  	  bool "Allow nfsd to export CIFS file system (EXPERIMENTAL)"
> -	  depends on CIFS && EXPERIMENTAL
> +	  depends on CIFS && NFSD && EXPERIMENTAL
>  	  help
>  	   Allows NFS server to export a CIFS mounted share (nfsd over cifs)

This looks ok, though I'd still prefer to see all of the nfs exporting
code removed. The cifs protocol has no consistent way to look up inodes
by filehandle and so it simply can never work.

Acked-by: Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux