On Tue, 22 Mar 2011 11:46:54 -0500 Steve French <smfrench@xxxxxxxxx> wrote: > On Tue, Mar 22, 2011 at 11:42 AM, Steve French <smfrench@xxxxxxxxx> wrote: > > Isn't there a lock across lseek? > > > >>> but how could we have PageDirty? ÂWe just did filemap_write_and_wait > >>> (unless some private mmap case where it may be ok?). > >>> > >> > >> Nothing prevents the page from being redirtied after writeback. > > If it is redirtied, we immediately do a filemap_fdatawrite anyway (in > the write/aio_write path) so there isn't a delay in writing data to > the server. > The bottom line is that you're asking to revalidate the file, finding that it has changed and are trying to invalidate the pagecache. Some of those pages are may not be invalidated though, so you won't end up with new data from the server if you go to do a read. The whole point of this patch is to fix data-integrity issues, right? So why only do a half-assed job of that? -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
