On Wed, 16 Mar 2011 01:55:32 +0300
Pavel Shilovsky <piastry@xxxxxxxxxxx> wrote:
> Use invalidate_inode_pages2 that don't leave pages even if shrink_page_list()
> has a temp ref on them. It prevents a data coherency problem when
> cifs_invalidate_mapping didn't invalidate pages but the client thinks that a data
> from the cache is uptodate according to an oplock level (exclusive or II).
>
> Signed-off-by: Pavel Shilovsky <piastry@xxxxxxxxxxx>
> ---
> fs/cifs/inode.c | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
> index 41e5651..adb6324 100644
> --- a/fs/cifs/inode.c
> +++ b/fs/cifs/inode.c
> @@ -1691,12 +1691,18 @@ cifs_invalidate_mapping(struct inode *inode)
>
> cifs_i->invalid_mapping = false;
>
> - /* write back any cached data */
> if (inode->i_mapping && inode->i_mapping->nrpages != 0) {
> + /* write back any cached data */
> rc = filemap_write_and_wait(inode->i_mapping);
> mapping_set_error(inode->i_mapping, rc);
> + rc = invalidate_inode_pages2(inode->i_mapping);
> + if (rc) {
> + cERROR(1, "%s: could not invalidate inode %p", __func__,
> + inode);
> + cifs_i->invalid_mapping = true;
> + }
> }
> - invalidate_remote_inode(inode);
> +
> cifs_fscache_reset_inode_cookie(inode);
> }
>
Hi Pavel,
I noticed that Steve has merged this patch, but it doesn't seem like
you ever made the change to have EBUSY percolate up to userspace. Are
you still planning to fix that?
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
