On 12/17/2010 08:38 PM, Jeff Layton wrote: > In later patches, we're going to need to have finer-grained control > over the addition and removal of these structs from the pending_mid_q > and we'll need to be able to call the destructor while holding the > spinlock. Move the locked sections out of both routines and into > the callers. Fix up current callers of DeleteMidQEntry to call a new > routine that dequeues the entry and then destroys it. > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > --- > fs/cifs/transport.c | 41 ++++++++++++++++++++++++----------------- > 1 files changed, 24 insertions(+), 17 deletions(-) > Looks good to me. Reviewed-by: Suresh Jayaraman <sjayaraman@xxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html