Re: [PATCH 04/18] cifs: clean up accesses to midCount

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/17/2010 08:38 PM, Jeff Layton wrote:
> It's an atomic_t and the code accesses the "counter" field in it directly
> instead of using atomic_read(). It also is sometimes accessed under a
> spinlock and sometimes not. Move it out of the spinlock since we don't need
> belt-and-suspenders for something that's just informational.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
>  fs/cifs/cifs_debug.c |    2 +-
>  fs/cifs/connect.c    |    2 +-
>  fs/cifs/transport.c  |    6 +++---
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 

Looks good to me.

Reviewed-by: Suresh Jayaraman <sjayaraman@xxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux