Re: [PATCH 2/2] CIFS: Add match_port check during looking for an existing connection (try #2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/11/16 Jeff Layton <jlayton@xxxxxxxxxx>:

>
> Now, to be pedantic...the code that Pavel proposed still isn't 100%
> compliant with the description. If someone specifies port=139 and the
> server is also listening on 445, a second mount with no port= option
> will end up using the socket on 139. Still, I think his patches are
> good enough here and that corner case really isn't worth sweating over
> too much.

Jeff, I think it fully follow the description I proposed today:

"port=arg

sets the port number on the server to attempt to contact to negotiate
CIFS support. If this value is specified, looking for an existing
connection with this port and try to connect if no such a connection.
Return an error if it fails.

If this value isn't specified, looking for an existing connection with
445 or 139 port. If no such a connection, try to connect with 445 port
and if it fails - with 139 port. Return an error if both fail."

So, in your case the second mount without port specifying will end up
with 139 and this is 100% compiliant with "If this value isn't
specified, looking for an existing connection with 445 or 139 port".

So, it means that servers on 445 and 139 ports can't live together on
the same host:)

-- 
Best regards,
Pavel Shilovsky.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux