Re: [PATCH 2/2] CIFS: Add match_port check during looking for an existing connection (try #2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 16, 2010 at 1:48 AM, Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote:
> If we have a share mounted by non-standard port and try to mount another share
> on the same host with standard port, we connect to the first share again -
> that's wrong. This patch fixes this bug.

The description seems a little strange - can you clarify?

If we have an existing session with a server (using whatever port), by
default we want to use it (unless the user forces a different port
than the existing connection was made with).  If we have a firewall
issue and therefore go through a non-standard port (port=something on
mount), we usually wouldn't want to fork a new connection on a second
connection to the same server.

So if we specify port=5000 on a mount and we already have a mount on
port 139, it makes sense that we would want to create a new session.
But if you already have a mount on port 5000, and did a mount with no
port specified - why wouldn't you use the existing port?  It saves
server, client and network resources.

-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux