On Tue, Sep 7, 2010 at 8:34 AM, Jeff Layton <jlayton@xxxxxxxxx> wrote: > On Mon, 6 Sep 2010 22:30:18 -0500 > shirishpargaonkar@xxxxxxxxx wrote: > >> Make NTLMv2 as a default authentication mechanism within NTLMSSP >> >> Enable cifs/smb signing >> >> Use Crypto sync hash APIs instead of cifs crypto functions to genereate >> various hashes such as arc4/rc4, md5, and hmac-md5 used during authentication >> and smb/cifs signature generation >> > > The patches almost all lack real descriptions. I'm not sure whether > that was intentional or not, but some of them could *really* use some > explanation. No, it was not inentional. Like the patch 8/8, I had comments/description in all of them. Will make sure the next spin has the description. > > Also, I don't think this patchset is really complete yet. The last > patch in this set should be "Remove old private CIFS crypto routines". > With the move to using the standard kernel crypto API, it seems like we > should have a net reduction in code or at least something closer to 0. > That would make it a lot easier to stomach taking in a large patchset > like this. I really would like to make it a separate patchset. It would be really cleaner IMHO to separate it as anohter patch. I can do that before end of the year but I do not have bandwidth right now to go through the entire code to delete the now unused functions. > > -- > Jeff Layton <jlayton@xxxxxxxxx> > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
