Re: [PATCH][linux-cifs][ntlmv2 in ntlmssp 0/8] - resend in small chunks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon,  6 Sep 2010 22:30:18 -0500
shirishpargaonkar@xxxxxxxxx wrote:

> Make NTLMv2 as a default authentication mechanism within NTLMSSP
> 
> Enable cifs/smb signing
> 
> Use Crypto sync hash APIs instead of cifs crypto functions to genereate
> various hashes such as arc4/rc4, md5, and hmac-md5 used during authentication
> and smb/cifs signature generation
> 

The patches almost all lack real descriptions. I'm not sure whether
that was intentional or not, but some of them could *really* use some
explanation.

Also, I don't think this patchset is really complete yet. The last
patch in this set should be "Remove old private CIFS crypto routines".
With the move to using the standard kernel crypto API, it seems like we
should have a net reduction in code or at least something closer to 0.
That would make it a lot easier to stomach taking in a large patchset
like this.

-- 
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux