On Fri, 27 Aug 2010 10:12:16 -0700 Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote: > On 08/27/2010 10:08 AM, Steve French wrote: > > On Fri, Aug 27, 2010 at 11:52 AM, Jeff Layton<jlayton@xxxxxxxxxx> wrote: > >> On Fri, 27 Aug 2010 08:29:49 -0700 > >> Ben Greear<greearb@xxxxxxxxxxxxxxx> wrote: > >> > >>> On 08/27/2010 06:54 AM, Jeff Layton wrote: > >>> > >>>>> Also, I think bindaddr might not be the best name for the option. How > >>>>> about sourceaddr or srcaddr? > >>>>> > >>>> > >>>> Sounds reasonable. > >>> > >>> It doesn't matter to me. Please tell me which one you want me to use > >>> and I'll work on re-spinning this patch with ipv6 support. > >>> > >>> Thanks, > >>> Ben > >>> > >> > >> My preference would be "srcaddr=". > > > > Shorter is good ... > > srcaddr wins unless we have a particular compatibility objective with > > other fs mounts (ie an existing mount option - which so far I have not > > been able to find). > > > > For completeness we should consider, at least briefly, one alternative name. > > Note that smb.conf (and thus smbclient indirectly uses this) can > > override the local interface using the optional smb.conf parm > > "interfaces" - we could shorten this to "interface" If anyone feels > > strongly about this being better ... > > I don't like that, as we're binding to IPs, not interfaces. > > If we ever need to support SO_BINDTODEV logic, then could > use interface= for that. > > srcaddr= sounds fine to me. > Agreed. The samba config option seems poorly named in that regard. They're sort of stuck with it though for legacy reasons, but there's no reason to saddle cifs with it. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
