Re: [PATCH net-next 03/20] arm64: dts: rockchip: mecsbc: add CAN0 and CAN1 interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04.09.2024 13:51:52, Krzysztof Kozlowski wrote:
> On 04/09/2024 11:38, Marc Kleine-Budde wrote:
> > From: David Jander <david@xxxxxxxxxxx>
> > 
> > This patch adds support for the CAN0 and CAN1 interfaces to the board.
> > 
> > Signed-off-by: David Jander <david@xxxxxxxxxxx>
> > Tested-by: Alibek Omarov <a1ba.omarov@xxxxxxxxx>
> > Link: https://patch.msgid.link/20240904-rockchip-canfd-v5-3-8ae22bcb27cc@xxxxxxxxxxxxxx
> > [mkl: fixed order of phandles]
> > Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
> > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts | 14 ++++++++++++++
> 
> DTS patches should never be taken via net/can or or any other driver
> subsystem.

Ok.

> DTS is independent hardware description. Embedding it here suggests
> there is dependency thus ABI break.

It might suggest, but it isn't.

> Please drop all DTS patches and never apply them via net.

Ok, will send an updated PR to net-next and an independent PR to
upstream the DTS changes.

regards
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux