On 08/08/2024 17:48, Conor Dooley wrote: > On Wed, Aug 07, 2024 at 09:09:56PM +0300, Ilya Orazov wrote: >> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode. >> It is pin-compatible with TI TCAN1042 and has a compatible programming >> model, therefore use ti,tcan1042 as fallback compatible. >> >> Signed-off-by: Ilya Orazov <ilordash02@xxxxxxxxx> >> --- >> .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++---- >> 1 file changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml >> index 79dad3e89aa6..f6f1fd843874 100644 >> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml >> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml >> @@ -14,10 +14,15 @@ properties: >> pattern: "^can-phy" >> >> compatible: >> - enum: >> - - nxp,tjr1443 >> - - ti,tcan1042 >> - - ti,tcan1043 >> + oneOf: >> + - items: >> + - enum: >> + - microchip,ata6561 >> + - const: ti,tcan1042 >> + - enum: >> + const: ti,tcan1042 >> + const: ti,tcan1043 >> + const: nxp,tjr1443 > > The enum doesn't need the "const:s", just a "-", hence the bot > complaining. Plus indentation is broken, which is important for YAML. Before posting the patch, please test it. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
