On 23.11.2023 07:08:24, Thomas.Kopp@xxxxxxxxxxxxx wrote:
> > [ 4493.557075] mcp251xfd spi1.2 can2: MCP2518FD rev0.0 (-RX_INT -PLL -
> > MAB_NO_WARN +CRC_REG +CRC_RX +CRC_TX +ECC -HD o:40.00MHz
> > c:40.00MHz m:8.00MHz rs:8.00MHz es:0.00MHz rf:8.00MHz ef:0.00MHz)
> > successfully initialized.
> I can't remember encountering these format errors before. Do you have
> access to a logic analyzer and can you spi during capture insmod +
> interface up?
>
> Do you have anything else on the same SPI? Where's the 8 MHz coming
> from? Did you limit this in your DT?
The "m:8.00MHz" is the maximum SPI speed the driver gets from the SPI
framework.
> You could try with -CRC_REG -CRC_RX -CRC_TX to see if you're able to
> communicate with the device (this is not suited for anything in
> production though)
Depending what you have in your DT, for a "microchip,mcp251xfd" it would
be this patch:
--- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
+++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
@@ -46,8 +46,8 @@ static const struct mcp251xfd_devtype_data mcp251xfd_devtype_data_mcp251863 = {
/* Autodetect model, start with CRC enabled. */
static const struct mcp251xfd_devtype_data mcp251xfd_devtype_data_mcp251xfd = {
- .quirks = MCP251XFD_QUIRK_CRC_REG | MCP251XFD_QUIRK_CRC_RX |
- MCP251XFD_QUIRK_CRC_TX | MCP251XFD_QUIRK_ECC,
+ .quirks = /* MCP251XFD_QUIRK_CRC_REG | MCP251XFD_QUIRK_CRC_RX | */
+ /* MCP251XFD_QUIRK_CRC_TX | */ MCP251XFD_QUIRK_ECC,
.model = MCP251XFD_MODEL_MCP251XFD,
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
