On 26.09.2023 23:10:52, Eric Stahl wrote: > I was beginning to familiarize myself with the ix_active_can drivers > for IXXAT CAN-IB2XX pci/pcie boards in an attempt to get IXXAT > pci/pcie drivers into the kernel. I noticed that the device driver > distributed by HMS > (https://www.ixxat.com/docs/librariesprovider8/ixxat-english-new/pc-can-interfaces/linux-drivers/socketcan-linux.tgz) > appears to be using the IFI CAN/CANFD core. There already appears to > be a kernel driver (ifi_canfd_plat_driver) that leverages the IFI > CAN/CANFD core. Should I continue to try to get the ix_active_can > drivers into the kernel or should I try to leverage the existing > ifi_canfd_plat_driver? If I should leverage the ifi_canfd_plat_driver, > what approach should I take to get it compatible with the IXXAT > pci/pcie cards? I think it's best reusing the existing driver. You can split the existing ifi_canfd_plat_probe() into a generic (i.e. ifi_canfd_probe()) and a platform driver specific part. The PCIe and the platform driver will alloc_candev() and fill out the bare minimum of that structure and the call into the generic ifi_canfd_probe(). regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
